Style: Reduce space consumed by headers and improve alignment#2533
Merged
hugovk merged 2 commits intoApr 19, 2022
python:mainpython/peps:mainfrom
CAM-Gerlach:style-reduce-header-spaceCAM-Gerlach/peps:style-reduce-header-spaceCopy head branch name to clipboard
Merged
Style: Reduce space consumed by headers and improve alignment#2533hugovk merged 2 commits intopython:mainpython/peps:mainfrom CAM-Gerlach:style-reduce-header-spaceCAM-Gerlach/peps:style-reduce-header-spaceCopy head branch name to clipboard
hugovk merged 2 commits into
python:mainpython/peps:mainfrom
CAM-Gerlach:style-reduce-header-spaceCAM-Gerlach/peps:style-reduce-header-spaceCopy head branch name to clipboard
Conversation
hugovk
approved these changes
Apr 16, 2022
hugovk
left a comment
Member
There was a problem hiding this comment.
Checked on desktop (Mac, Chrome) and mobile (Samsung S10, Chrome) and looks good.
I'm mindful we shouldn't be squashing things too tightly together, but this is fine.
Thanks!
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on #2514 , the headers at the top consume excessive vertical space, particularly on mobile which some style tweaks could dramatically improve with no loss of information. Furthermore, there are some odd gaps and spacing between the various elements that could be fixed, and the title and PEP number is redundant and can be removed, as it is present no less than four other places (the main title, the breadcrumbs, the sidebar [as addressed by #2532], and the tab title).
To note, while it is included in the comparisons below, this PR defers the implementation of removing or
abbr-ing the email address to a followup PR, as it may require a bit more discussion and is better done after #2484 is merged.Desktop (Before/After)
Mobile (Before/Previous/Latest)
Fixes #2514