Set low priority for rm-ing refs section so refs still resolve correctly#2227
Merged
JelleZijlstra merged 1 commit intoJan 12, 2022
python:mainpython/peps:mainfrom
CAM-Gerlach:fix-refs-legacy-buildCAM-Gerlach/peps:fix-refs-legacy-buildCopy head branch name to clipboard
Merged
Set low priority for rm-ing refs section so refs still resolve correctly#2227JelleZijlstra merged 1 commit intopython:mainpython/peps:mainfrom CAM-Gerlach:fix-refs-legacy-buildCAM-Gerlach/peps:fix-refs-legacy-buildCopy head branch name to clipboard
JelleZijlstra merged 1 commit into
python:mainpython/peps:mainfrom
CAM-Gerlach:fix-refs-legacy-buildCAM-Gerlach/peps:fix-refs-legacy-buildCopy head branch name to clipboard
Conversation
JelleZijlstra
approved these changes
Jan 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a followup to #2155 (and thus related to #2130 ), this sets a low priority to removing the references section, to fix link references not resolving for some cases on the legacy build system (
pep2html.py) where the references section gets removed if it would render empty, as apparently otherwise it is removed before it is needed to resolve the refs. Not sure how I didn't catch those cases in testing, but this simple tweak fixes it. Since this breaks proper link resolution on certain PEPs (at least those using multi-layer reference indirection, like PEP 639) and fixes a regression, it would be appreciated to merge this promptly. Sorry for not spotting this earlier!CC: @AA-Turner