Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Sphinx - PEP 0 generation#1932

Merged
pablogsal merged 37 commits into
python:masterpython/peps:masterfrom
AA-Turner:sphinx-pep-zeroAA-Turner/peps:sphinx-pep-zeroCopy head branch name to clipboard
Jun 12, 2021
Merged

Sphinx - PEP 0 generation#1932
pablogsal merged 37 commits into
python:masterpython/peps:masterfrom
AA-Turner:sphinx-pep-zeroAA-Turner/peps:sphinx-pep-zeroCopy head branch name to clipboard

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Apr 20, 2021

Copy link
Copy Markdown
Member

See #2, #1385 for context. Superseeds #1567.

This is the PEP 0 generation part, building on PR #1930. It contains the logic for parsing all PEPs and building the PEP index:

  • PEP 0 parser - Parses PEP and Author data
  • PEP 0 writer - Writes actual PEP-0000.rst file
  • PEP 0 generator Orchestrates process, entry point & docutils integration
  • AUTHORS.csv - explicit author overrides

Note that this PR also contains elements from PR #1386.

@AA-Turner AA-Turner requested a review from a team as a code owner April 20, 2021 22:34
@AA-Turner AA-Turner mentioned this pull request May 5, 2021
Closed
@AA-Turner AA-Turner force-pushed the sphinx-pep-zero branch 3 times, most recently from 5faec5d to 1439cad Compare May 7, 2021 15:05
@pablogsal

pablogsal commented Jun 8, 2021

Copy link
Copy Markdown
Member

This also needs rebasing

@AA-Turner

AA-Turner commented Jun 8, 2021

Copy link
Copy Markdown
Member Author

Rebased

@AA-Turner AA-Turner mentioned this pull request Jun 9, 2021
Merged
@pablogsal

pablogsal commented Jun 9, 2021

Copy link
Copy Markdown
Member

Moar rebasing 😉

@AA-Turner

AA-Turner commented Jun 9, 2021

Copy link
Copy Markdown
Member Author

yup, one sec

@AA-Turner

AA-Turner commented Jun 9, 2021

Copy link
Copy Markdown
Member Author

rebased take 2

@pablogsal

pablogsal commented Jun 9, 2021

Copy link
Copy Markdown
Member

Can you give me some context on why we need the authors override file? I have a guess but I would like to know the extent of the problem and why is needed now and not before.

pablogsal
pablogsal reviewed Jun 9, 2021
View reviewed changes
Comment thread pep_sphinx_extensions/pep_zero_generator/pep_0_writer.py Outdated
pablogsal
pablogsal reviewed Jun 9, 2021
View reviewed changes
Comment thread pep_sphinx_extensions/pep_zero_generator/pep_0_parser.py Outdated
@AA-Turner

AA-Turner commented Jun 9, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

Can you give me some context on why we need the authors override file? I have a guess but I would like to know the extent of the problem and why is needed now and not before.

as authors names were parsed wrong / duplicates missed (currently on /dev/python/)

prev discussion:
#2 (comment)
#1386 (comment)
#1386 (comment)

why not before - no idea, but I like to leave things better than I found them

pablogsal
pablogsal reviewed Jun 9, 2021
View reviewed changes
Comment thread pep_sphinx_extensions/pep_zero_generator/pep_0_parser.py Outdated
pablogsal
pablogsal reviewed Jun 9, 2021
View reviewed changes
Comment thread pep_sphinx_extensions/pep_zero_generator/pep_0_parser.py Outdated
pablogsal
pablogsal reviewed Jun 9, 2021
View reviewed changes
Comment thread pep_sphinx_extensions/pep_zero_generator/pep_0_parser.py Outdated
pablogsal
pablogsal reviewed Jun 9, 2021
View reviewed changes
Comment thread pep_sphinx_extensions/pep_zero_generator/pep_0_parser.py Outdated
@pablogsal

pablogsal commented Jun 9, 2021

Copy link
Copy Markdown
Member

prev discussion:

I assume https://github.com/python/peps/pull/1386/files is included here no?

@AA-Turner

AA-Turner commented Jun 9, 2021

Copy link
Copy Markdown
Member Author

prev discussion:

I assume #1386 (files) is included here no?

yes

@pablogsal

pablogsal commented Jun 9, 2021

Copy link
Copy Markdown
Member

Will make another pass tomorrow :)

@AA-Turner

AA-Turner commented Jun 9, 2021

Copy link
Copy Markdown
Member Author

@pablogsal done, and fixed that I accidentally left out the hook into the Sphinx build process!

Apart from that some refactoring for ease of reading / future maintenence - the PEP 0 generation was the area I hadn't touched much as slightly scared to break it!

pablogsal
pablogsal reviewed Jun 10, 2021
View reviewed changes
Comment thread pep_sphinx_extensions/pep_zero_generator/writer.py Outdated
@pablogsal

pablogsal commented Jun 10, 2021

Copy link
Copy Markdown
Member

Left one comment, otherwise looks good to me

pablogsal
pablogsal reviewed Jun 10, 2021
View reviewed changes
Comment thread pep_sphinx_extensions/pep_zero_generator/parser.py
@pablogsal pablogsal merged commit 749c2d9 into python:master Jun 12, 2021
@AA-Turner AA-Turner deleted the sphinx-pep-zero branch July 4, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees

No one assigned

Labels

CLA signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AA-Turner @pablogsal @the-knights-who-say-ni
Morty Proxy This is a proxified and sanitized view of the page, visit original site.