Hello, and thanks for your contribution!

Unfortunately we couldn't find an account corresponding
to your GitHub username at bugs.python.org (b.p.o).
If you don't already have an account at b.p.o, please
create one and make sure to
add your GitHub username. If you do already have an account at b.p.o then
please go there and under "Your Details" add your GitHub username.

And in case you haven't already, please make sure to sign the
PSF contributor agreement
(CLA); we can't legally look at your contribution until you have signed the
CLA.

Once you have done everything that's needed, please reply here and someone will
verify everything is in order.

Thanks. In addition to what the Knight said, please squash the commits in the pep-2-rst branch.

GitHub User name update on b.p.o, so Knight will likely change to CLA Signed

please squash the commits in the pep-2-rst branch.

Sure thing. Do you know that GitHub can do that for you when you press the green merge button ?

Rebased and force pushed.

Do you know that GitHub can do that for you when you press the green merge button ?

Yes, I know but we don't always have a chance to do all the review and testing steps via GitHub UI (in this case we need to pull the branch locally and build the HTML version of the file) so it would be nice to avoid the rebasing step as a reviewer :)

Yes, I know but we don't always have a chance to do all the review and testing steps via GitHub UI (in this case we need to pull the branch locally and build the HTML version of the file) so it would be nice to avoid the rebasing step as a reviewer :)

Fair enough :-)

Even in RST format, PEPs are supposed to be wrapped at 70 chars.

Even in RST format, PEPs are supposed to be wrapped at 70 chars.

Sorry I missunderstood the 70char/79char statement in the pep.
rewrapped at 70.

in this case we need to pull the branch locally and build the HTML version of the file; so it would be nice to avoid the rebasing step as a reviewer

See auto generated version here :

https://carreau.github.io/peps/render-pep-2-rst/pep-0002.html

Also Tip:

$ cat ~/.gitconfig
<snip>
[remote "origin"]
    fetch = +refs/pull/*/head:refs/remotes/origin/pr/*
<snip>

and you can now do :

$ git fetch 
<snip>
$ git checkout origin/pr/<number>

Merged in cce5754, thanks! Already have an alias set for that command.

Just a quick thing for @berkerpeksag : don't worry about squashing commits for PEPs. No one really reads the commit history for PEPs regularly for any critical reason and so it's more important to make our lives easier to accept PRs than it is to keep a clean commit history.

That argument doesn't really justify having commits like "fix", "typo", "f* bash" in an official Python repository.

Oops, that I usually rebased /ammend after I test. Agree that commit
messages should be cleaned. Sorry if I missed one.
On Jun 20, 2016 10:35, "Berker Peksag" notifications@github.com wrote:

That argument doesn't really justify having commits like "fix", "typo",
"f* bash" in an official Python repository.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#16 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAUez8KHamQ0rTh9wS0qY5DUJHpK4-hnks5qNs98gaJpZM4I5De9
.