PEP 633: Exploded dependencies for PEP 621#1595
Merged
brettcannon merged 57 commits intoSep 14, 2020
python:masterpython/peps:masterfrom
EpicWink:pep-621-exploded-dependenciesEpicWink/peps:pep-621-exploded-dependenciesCopy head branch name to clipboard
Merged
PEP 633: Exploded dependencies for PEP 621#1595brettcannon merged 57 commits intopython:masterpython/peps:masterfrom EpicWink:pep-621-exploded-dependenciesEpicWink/peps:pep-621-exploded-dependenciesCopy head branch name to clipboard
brettcannon merged 57 commits into
python:masterpython/peps:masterfrom
EpicWink:pep-621-exploded-dependenciesEpicWink/peps:pep-621-exploded-dependenciesCopy head branch name to clipboard
Conversation
* Allow environment markers as keys * Add white-space before marker separator in PEP 508 conversion * Add note on reason for marker key transformation * Add note on 'extra' marker
This reverts commit 375aea5.
* Convert optional-deps to table of reqs with extra key * Fix optional-dependencies in docker-compose example * Add note on 'for-extras' key
* Add PEP 508 compatibility examples Initial set of examples demonstrating compatibility with PEP 508. * Fix typo in example version constraint * Add a note for version only dependency * Add missing new line * Update vcs examples * Fix markers example * Fix missing markers * Replace for-extras with for-extra
brettcannon
requested changes
Sep 11, 2020
brettcannon
left a comment
Member
There was a problem hiding this comment.
The PR doesn't have the "let maintainers make changes" checkbox set, so I can't merge these final changes. Add these and then I can merge the PEP!
brettcannon
reviewed
Sep 11, 2020
brettcannon
requested changes
Sep 11, 2020
Comment on lines
+28
to
+40
| - Easy initial validation via the TOML syntax. | ||
|
|
||
| - Easy secondary validation using a schema, for example a `JSON Schema`_. | ||
|
|
||
| - Potential for users to guess the keys of given features, rather than | ||
| memorising a syntax. | ||
|
|
||
| - Users of multiple other popular languages may already be familiar with the | ||
| TOML syntax. | ||
|
|
||
| - TOML directly represents the same data structures as in JSON, and therefore a | ||
| sub-set of Python literals, so users can understand the hierarchy and type of | ||
| value |
Member
There was a problem hiding this comment.
Suggested change
| - Easy initial validation via the TOML syntax. | |
| - Easy secondary validation using a schema, for example a `JSON Schema`_. | |
| - Potential for users to guess the keys of given features, rather than | |
| memorising a syntax. | |
| - Users of multiple other popular languages may already be familiar with the | |
| TOML syntax. | |
| - TOML directly represents the same data structures as in JSON, and therefore a | |
| sub-set of Python literals, so users can understand the hierarchy and type of | |
| value | |
| - Easy initial validation via the TOML syntax. | |
| - Easy secondary validation using a schema, for example a `JSON Schema`_. | |
| - Potential for users to guess the keys of given features, rather than | |
| memorising a syntax. | |
| - Users of multiple other popular languages may already be familiar with the | |
| TOML syntax. | |
| - TOML directly represents the same data structures as in JSON, and therefore a | |
| sub-set of Python literals, so users can understand the hierarchy and type of | |
| value |
Does this render appropriately with the newlines between the bullet points?
Contributor
Author
There was a problem hiding this comment.
make pep-9999.html doesn't show any issues
Co-authored-by: Brett Cannon <brett@python.org>
Co-authored-by: Brett Cannon <brett@python.org>
Co-authored-by: Brett Cannon <brett@python.org>
Co-authored-by: Brett Cannon <brett@python.org>
Co-authored-by: Brett Cannon <brett@python.org>
Co-authored-by: Brett Cannon <brett@python.org>
Co-authored-by: Brett Cannon <brett@python.org>
Co-authored-by: Brett Cannon <brett@python.org>
brettcannon
approved these changes
Sep 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency format proposal for PEP 621; see discussions at: https://discuss.python.org/t/pep-621-how-to-specify-dependencies/4599
Discuss at: https://discuss.python.org/t/dependency-specification-in-pyproject-toml-using-an-exploded-toml-table/5123
TODO:
Future: