Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

PEP 599: manylinux2014 PEP#1121

Merged
ncoghlan merged 10 commits into
python:masterpython/peps:masterfrom
di:manylinux2014di/peps:manylinux2014Copy head branch name to clipboard
Jul 20, 2019
Merged

PEP 599: manylinux2014 PEP#1121
ncoghlan merged 10 commits into
python:masterpython/peps:masterfrom
di:manylinux2014di/peps:manylinux2014Copy head branch name to clipboard

Conversation

@di

@di di commented Jul 10, 2019

Copy link
Copy Markdown
Member

Comment thread pep-9999.rst Outdated
Comment thread pep-9999.rst
brettcannon
brettcannon previously approved these changes Jul 11, 2019
@brettcannon brettcannon requested review from brettcannon and removed request for brettcannon July 11, 2019 19:43
@brettcannon brettcannon dismissed their stale review July 11, 2019 19:44

Accidentally approved a single commit

@brettcannon brettcannon removed their request for review July 11, 2019 19:44
@di

di commented Jul 11, 2019

Copy link
Copy Markdown
Member Author

@brettcannon Did you mean to approve the entire PR?

@brettcannon

Copy link
Copy Markdown
Member

@di if you look at the issue history you will see I dismissed my review with the comment "accidentally approved" 😁 .

@di

di commented Jul 18, 2019

Copy link
Copy Markdown
Member Author

This has been open for 1 week without additional comments. Can someone assign this a PEP # and merge? @brettcannon / @pfmoore / @ncoghlan?

Comment thread pep-9999.rst Outdated
@di di force-pushed the manylinux2014 branch from 0196a58 to df1f13d Compare July 18, 2019 16:51
@brettcannon

Copy link
Copy Markdown
Member

@di at this point you just need to add a sponsor.

@di

di commented Jul 18, 2019

Copy link
Copy Markdown
Member Author

@pfmoore, are you willing to act as "sponsor" here?

@pfmoore

pfmoore commented Jul 18, 2019

Copy link
Copy Markdown
Member

Given that I'm deciding between the 2 alternative proposals, is that appropriate? @brettcannon what's your view here? If it's OK for the BDFL-delegate to also be the sponsor, I'm fine with sponsoring this (although I'd have to say, I'm not entirely sure what the role of sponsor involves).

@di

di commented Jul 18, 2019

Copy link
Copy Markdown
Member Author

PEP 1 says:

The sponsor's job is to provide guidance to the PEP author to help them through the logistics of the PEP process (somewhat acting like mentor). For the core developer sponsoring, being a sponsor does not disqualify them from becoming a co-author or BDFL-Delegate later on

So, more or less a formality here it seems, given that the "PEP process" is mostly completed.

Comment thread pep-9999.rst Outdated
Comment thread pep-9999.rst Outdated
@brettcannon

Copy link
Copy Markdown
Member

@pfmoore as @di quoted, a sponsor acts as a mentor/guide to someone going through the PEP process. You could be totally for/against the PEP and still be a sponsor to help Dustin with the overall process.

@pfmoore

pfmoore commented Jul 19, 2019

Copy link
Copy Markdown
Member

Cool - @di I'm happy to be the sponsor in that case.

@ncoghlan ncoghlan self-assigned this Jul 20, 2019
@ncoghlan

Copy link
Copy Markdown
Contributor

Assigning 599 and 600 to this PEP and the perennial manylinux proposal.

@ncoghlan ncoghlan changed the title manylinux2014 PEP PEP 599: manylinux2014 PEP Jul 20, 2019
@ncoghlan ncoghlan merged commit a5edd3d into python:master Jul 20, 2019
@di di deleted the manylinux2014 branch July 20, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.