Preserve escaped test data section lines#21774
Open
tarun-bandi wants to merge 1 commit into
python:masterpython/mypy:masterfrom
tarun-bandi:agent/preserve-update-data-escapestarun-bandi/mypy:agent/preserve-update-data-escapesCopy head branch name to clipboard
Open
Preserve escaped test data section lines#21774tarun-bandi wants to merge 1 commit intopython:masterpython/mypy:masterfrom tarun-bandi:agent/preserve-update-data-escapestarun-bandi/mypy:agent/preserve-update-data-escapesCopy head branch name to clipboard
tarun-bandi wants to merge 1 commit into
python:masterpython/mypy:masterfrom
tarun-bandi:agent/preserve-update-data-escapestarun-bandi/mypy:agent/preserve-update-data-escapesCopy head branch name to clipboard
Conversation
tarun-bandi
force-pushed
the
agent/preserve-update-data-escapes
branch
from
July 25, 2026 04:07
a27210e to
398a49e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17465.
parse_test_data()unescapes lines that begin with\[so they can be treated as source text rather than.testsection headers. When--update-datarewrites a test case, it was writing the parsed source line back directly, so an escaped line such as\[mypy]became[mypy]and could be parsed as a new section on the next run.This keeps updated source lines escaped when they would otherwise look like section headers after being written back. It covers both unchanged lines in
[file ...]sections and source lines that gain an inline# E:comment ending with an error code.Validation:
/Users/bandi/Documents/Codex/2026-07-24/new-chat/work/mypy_venv/bin/python -m pytest mypy/test/test_update_data.py -qPYTHONPYCACHEPREFIX=/Users/bandi/Documents/Codex/2026-07-24/new-chat/work/.pycache /Users/bandi/Documents/Codex/2026-07-24/new-chat/work/mypy_venv/bin/python -m py_compile mypy/test/update_data.py mypy/test/test_update_data.pygit diff --cached --check