Better match narrowing for irrefutable sequence patterns#20782
Merged
Merged
Better match narrowing for irrefutable sequence patterns#20782
Conversation
The changes around narrow_sequence_child: - implement my suggestion from here: python#18091 (review) - remove an is_subtype check I don't understand
Closed
for more information, see https://pre-commit.ci
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Collaborator
Author
|
Will merge this one tomorrow |
JukkaL
approved these changes
Feb 19, 2026
This was referenced Feb 25, 2026
hauntsaninja
added a commit
that referenced
this pull request
Mar 4, 2026
Fixes #18950 Fixes this comment #19081 (comment) (previously improved on by #20744 and #20782 )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes around narrow_sequence_child:
Fixes #13955
Helps with things in #19081