Fix cmdline package tests for namespace packages#11323
Merged
Merged
Fix cmdline package tests for namespace packages#11323
Conversation
JelleZijlstra
approved these changes
Oct 12, 2021
Prep for python#9636 First test was failing because a was not a valid import (pkg.a was) Second test was failing because `foo.py` resolved in two ways, both as `foo` and `foo.foo`. Disambiguating the dir from the file made mypy path work better. The error message was very clear. Came up once foo can be a namespace package.
Contributor
Author
|
Needs rebase on #11324 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prep for #9636
First test was failing because a was not a valid import (pkg.a was)
Second test was failing because
foo.pyresolved in two ways, bothas
fooandfoo.foo. Disambiguating the dir from the file mademypy path work better. The error message was very clear. Came up once
foo can be a namespace package.
Confirmed that all these tests pass here - as well as on top of #9636