Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Remove Python 2 virtualenv tests#10846

Closed
hauntsaninja wants to merge 2 commits into
python:masterpython/mypy:masterfrom
hauntsaninja:py2hauntsaninja/mypy:py2Copy head branch name to clipboard
Closed

Remove Python 2 virtualenv tests#10846
hauntsaninja wants to merge 2 commits into
python:masterpython/mypy:masterfrom
hauntsaninja:py2hauntsaninja/mypy:py2Copy head branch name to clipboard

Conversation

@hauntsaninja

Copy link
Copy Markdown
Collaborator

Resolves #10407 as well as the mysteriously suddenly broken tests on
master.

hauntsaninja added 2 commits July 20, 2021 21:11
Resolves python#10407 as well as the mysteriously suddenly broken tests on
master.
@emmatyping

Copy link
Copy Markdown
Member

Yeah I think there's another issue with Windows, I'll try to look at it tonight.

@hauntsaninja hauntsaninja marked this pull request as draft July 21, 2021 05:46
@hauntsaninja

hauntsaninja commented Jul 21, 2021

Copy link
Copy Markdown
Collaborator Author

The Windows failures look the same as the non-Windows failures to me... I was a little confused because tests passed locally, but tests on my laptop were getting skipped by

if (sys.platform == 'darwin' and hasattr(sys, 'base_prefix') and

A look would be welcome! It's not immediately obvious to me what's wrong / why it's picking up the stubs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Virtualenv pinned to <20

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.