Merged
Conversation
Remove the part about merging into master. Remove the part about prefixing the PR title with `X.Y`, cherry_picker.py already does this. Closes #173
willingc
approved these changes
Apr 25, 2017
|
|
||
| Backporting changes to Python 3.6 (or older version) | ||
| ---------------------------------------------------- | ||
| Backporting Changes to Older Version |
Collaborator
There was a problem hiding this comment.
@Mariatta: Should there be an an before Older Version?
Member
Author
|
Thanks :) Updated. |
willingc
approved these changes
Apr 25, 2017
Member
|
I think the part about prefixing PR title should stay for now. Not every core dev use cherry_picker.py yet :) |
Collaborator
|
A reasonable comment during the transition @berkerpeksag. Perhaps adding a small note about prefixing the PR title and marking it "legacy process" and the cherry_picker.py as the "preferred process". @Mariatta thoughts? |
Member
Author
|
Sounds reasonable :) I'm reviewing the other PR now, and will add back the PR prefix after. |
AA-Turner
pushed a commit
to AA-Turner/devguide
that referenced
this pull request
Jun 17, 2022
* Update backport instructions Remove the part about merging into master. Remove the part about prefixing the PR title with `X.Y`, cherry_picker.py already does this. Closes python#173 * hash -> hashes * add `an`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the part about merging into master.
Remove the part about prefixing the PR title with
X.Y, cherry_picker.py already does this.Closes #173