bpo-34996: Add name parameter to multiprocessing.Pool#9906
bpo-34996: Add name parameter to multiprocessing.Pool#9906RazManorAllegro wants to merge 5 commits into
Conversation
Contributed byt Allegro.ai
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
|
Hi @RazManorAllegro , Can you please change the title to You can find more information about the process : https://devguide.python.org/ Thanks |
| @@ -0,0 +1 @@ | ||
| Add name paramter to process and thread pool |
There was a problem hiding this comment.
after the CLA signed, could you fix the typo?
| """ | ||
| for i in range(processes - len(pool)): | ||
| w = Process(ctx, target=worker, | ||
| name='{}-Worker-{}'.format(name, i), |
There was a problem hiding this comment.
make patchcheck fails in CI in this line due to alignment. Please run make patchcheck locally that fixes this issue for you so that it's aligned with ctx and args .
|
Apologies if there were multiple notifications for my comment I wasn't aware of the GitHub outage and clicked on submit 4-5 times thinking it was a network issue from my end. |
|
Thanks for the PR, but closing as the CLA has not been signed within the last month. If you do decide to sign the CLA we can re-open this PR. |
Contributed byt Allegro.ai
https://bugs.python.org/issue34996