[3.10] gh-97527: IDLE - fix buggy macosx patch (GH-98313)#98330
Merged
miss-islington merged 1 commit intoOct 16, 2022
python:3.10python/cpython:3.10from
miss-islington:backport-35fa5d5-3.10miss-islington/cpython:backport-35fa5d5-3.10Copy head branch name to clipboard
Merged
[3.10] gh-97527: IDLE - fix buggy macosx patch (GH-98313)#98330miss-islington merged 1 commit intopython:3.10python/cpython:3.10from miss-islington:backport-35fa5d5-3.10miss-islington/cpython:backport-35fa5d5-3.10Copy head branch name to clipboard
miss-islington merged 1 commit into
python:3.10python/cpython:3.10from
miss-islington:backport-35fa5d5-3.10miss-islington/cpython:backport-35fa5d5-3.10Copy head branch name to clipboard
Conversation
pythonGH-97530 fixed IDLE tests possibly crashing on a Mac without a GUI. But it resulted in IDLE not starting in 3.10.8, 3.12.0a1, and Microsoft Python 3.10.2288.0 when test/* is not installed. After this patch, test.* is only imported when testing on Mac. (cherry picked from commit 35fa5d5) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
terryjreedy
approved these changes
Oct 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GH-97530 fixed IDLE tests possibly crashing on a Mac without a GUI.
But it resulted in IDLE not starting in 3.10.8, 3.12.0a1, and
Microsoft Python 3.10.2288.0 when test/* is not installed.
After this patch, test.* is only imported when testing on Mac.
(cherry picked from commit 35fa5d5)
Co-authored-by: Terry Jan Reedy tjreedy@udel.edu