Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[3.7] bpo-32962: Fix test_gdb failure in debug build with -mcet -fcf-protection -O0 (GH-9656)#9770

Merged
miss-islington merged 1 commit into
python:3.7python/cpython:3.7from
miss-islington:backport-79d2133-3.7miss-islington/cpython:backport-79d2133-3.7Copy head branch name to clipboard
Oct 9, 2018
Merged

[3.7] bpo-32962: Fix test_gdb failure in debug build with -mcet -fcf-protection -O0 (GH-9656)#9770
miss-islington merged 1 commit into
python:3.7python/cpython:3.7from
miss-islington:backport-79d2133-3.7miss-islington/cpython:backport-79d2133-3.7Copy head branch name to clipboard

Conversation

@miss-islington

@miss-islington miss-islington commented Oct 9, 2018

Copy link
Copy Markdown
Contributor

When Python is built with the intel control-flow protection flags,
-mcet -fcf-protection, gdb is not able to read the stack without
actually jumping inside the function. This means an extra
'next' command is required to make the $pc (program counter)
enter the function and make the stack of the function exposed to gdb.

Co-Authored-By: Marcel Plch gmarcel.plch@gmail.com

(cherry picked from commit 9b7c74c)
(cherry picked from commit 79d2133)

Co-authored-by: Victor Stinner vstinner@redhat.com

https://bugs.python.org/issue32962

…tion -O0 (pythonGH-9656)

When Python is built with the intel control-flow protection flags,
-mcet -fcf-protection, gdb is not able to read the stack without
actually jumping inside the function. This means an extra
'next' command is required to make the $pc (program counter)
enter the function and make the stack of the function exposed to gdb.

Co-Authored-By: Marcel Plch <gmarcel.plch@gmail.com>

(cherry picked from commit 9b7c74c)
(cherry picked from commit 79d2133)

Co-authored-by: Victor Stinner <vstinner@redhat.com>

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 0ce31d3 into python:3.7 Oct 9, 2018
@miss-islington miss-islington deleted the backport-79d2133-3.7 branch October 9, 2018 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.