[3.11] gh-97527: IDLE: protect macosx Tk() call when no GUI (GH-97530)#97531
Merged
miss-islington merged 1 commit intoSep 24, 2022
python:3.11python/cpython:3.11from
miss-islington:backport-9704f8d-3.11miss-islington/cpython:backport-9704f8d-3.11Copy head branch name to clipboard
Merged
[3.11] gh-97527: IDLE: protect macosx Tk() call when no GUI (GH-97530)#97531miss-islington merged 1 commit intopython:3.11python/cpython:3.11from miss-islington:backport-9704f8d-3.11miss-islington/cpython:backport-9704f8d-3.11Copy head branch name to clipboard
miss-islington merged 1 commit into
python:3.11python/cpython:3.11from
miss-islington:backport-9704f8d-3.11miss-islington/cpython:backport-9704f8d-3.11Copy head branch name to clipboard
Conversation
…97530) Only call tkinter.tk and its follow-up code in _init_tk_type when requires('gui') does not raise. This function can be called as an unintended side-effect of calling other idlelib code as part of tests on macOS without a GUI enabled. (cherry picked from commit 9704f8d) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
terryjreedy
approved these changes
Sep 24, 2022
Contributor
Author
|
Status check is done, and it's a success ✅. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only call tkinter.tk and its follow-up code in _init_tk_type when requires('gui')
does not raise. This function can be called as an unintended side-effect of
calling other idlelib code as part of tests on macOS without a GUI enabled.
(cherry picked from commit 9704f8d)
Co-authored-by: Terry Jan Reedy tjreedy@udel.edu