Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-34901: add isolated (-I) flag to sys.flags#9708

Merged
miss-islington merged 1 commit into
python:masterpython/cpython:masterfrom
danishprakash:fix-issue-34901danishprakash/cpython:fix-issue-34901Copy head branch name to clipboard
Oct 7, 2018
Merged

bpo-34901: add isolated (-I) flag to sys.flags#9708
miss-islington merged 1 commit into
python:masterpython/cpython:masterfrom
danishprakash:fix-issue-34901danishprakash/cpython:fix-issue-34901Copy head branch name to clipboard

Conversation

@danishprakash

@danishprakash danishprakash commented Oct 5, 2018

Copy link
Copy Markdown
Contributor

@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

Comment thread Doc/library/sys.rst Outdated

@ned-deily ned-deily left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and the update!

@miss-islington miss-islington merged commit 656d52d into python:master Oct 7, 2018
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @danishprakash for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 7, 2018
https://bugs.python.org/issue34901
(cherry picked from commit 656d52d)

Co-authored-by: Danish Prakash <grafitykoncept@gmail.com>
@bedevere-bot

Copy link
Copy Markdown

GH-9749 is a backport of this pull request to the 3.7 branch.

@miss-islington

Copy link
Copy Markdown
Contributor

Sorry, @danishprakash, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 656d52dbfde3223cd2a3525d652b6cccb02fa991 3.6

@miss-islington miss-islington self-assigned this Oct 7, 2018
miss-islington added a commit that referenced this pull request Oct 7, 2018
https://bugs.python.org/issue34901
(cherry picked from commit 656d52d)

Co-authored-by: Danish Prakash <grafitykoncept@gmail.com>
@ned-deily

Copy link
Copy Markdown
Member

@danishprakash, if you have time and are so inclined, it would be nice if you could do a manual backport to 3.6.

@danishprakash

danishprakash commented Oct 8, 2018

Copy link
Copy Markdown
Contributor Author

@ned-deily definitely, I assume it requires me to cherry-pick the commit as mentioned above and then open a PR against the 3.6 branch, is that right?

@tirkarthi

Copy link
Copy Markdown
Member

@danishprakash Yes, you can install cherry_picker from PyPI and run the command mentioned which will help you.

@ned-deily

Copy link
Copy Markdown
Member

@danishprakash Yes, that's right. You can use follow the process here or just manually use the git cherry-pick command.

@bedevere-bot

Copy link
Copy Markdown

GH-9755 is a backport of this pull request to the 3.6 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.