[WIP] bpo-33608: Factor out a private, per-interpreter _Py_AddPendingCall().#9334
Closed
ericsnowcurrently wants to merge 18 commits into
python:masterpython/cpython:masterfrom
ericsnowcurrently:pending-calls-freshericsnowcurrently/cpython:pending-calls-freshCopy head branch name to clipboard
Closed
[WIP] bpo-33608: Factor out a private, per-interpreter _Py_AddPendingCall().#9334ericsnowcurrently wants to merge 18 commits intopython:masterpython/cpython:masterfrom ericsnowcurrently:pending-calls-freshericsnowcurrently/cpython:pending-calls-freshCopy head branch name to clipboard
ericsnowcurrently wants to merge 18 commits into
python:masterpython/cpython:masterfrom
ericsnowcurrently:pending-calls-freshericsnowcurrently/cpython:pending-calls-freshCopy head branch name to clipboard
Conversation
5 tasks
Member
Author
|
Superceded by gh-11617 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of the work to improve isolation between subinterpreters. We need a way for one interpreter to ask another interpreter to do small low-level tasks, like safely decref an object owned by the other interpreter. The existing
Py_AddPendingCall()(part of the public C-API) is specific to the main interpreter, so we factor out a private per-interpreter_Py_AddPendingCall(). This involves moving the global "pending calls" state toPyInterpreterState.As part of this change, we start tracking if each interpreter is "active" or finalizing. "Active" means that the interpreter is currently running the eval loop. We also start tracking the per-interpreter "active" thread ID rather than the global "main" thread ID.
https://bugs.python.org/issue33608