Update authors for Required[] and NotRequired[] implementation#91506
Merged
JelleZijlstra merged 1 commit intoApr 13, 2022
python:mainpython/cpython:mainfrom
davidfstr:f/required_attributiondavidfstr/cpython:f/required_attributionCopy head branch name to clipboard
Merged
Update authors for Required[] and NotRequired[] implementation#91506JelleZijlstra merged 1 commit intopython:mainpython/cpython:mainfrom davidfstr:f/required_attributiondavidfstr/cpython:f/required_attributionCopy head branch name to clipboard
JelleZijlstra merged 1 commit into
python:mainpython/cpython:mainfrom
davidfstr:f/required_attributiondavidfstr/cpython:f/required_attributionCopy head branch name to clipboard
Conversation
Member
|
Sorry for missing this! |
Contributor
Author
No worries. Thanks for helping getting the implementation through! (I'm literally at the beach now, so it's nice to have help getting this change in before Beta.) I'm looking forward to making some headway on related (Not)Required[] docs soon - probably next week if I can get Typing Summit stuff finished far enough. |
Member
|
I hope you have a great vacation! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate feedback from @JelleZijlstra on recently merged PR #32419 (comment) .