bpo-34443: Change enum __repr__s and __str__s to use the fully qualified name#9011
Closed
orlnub123 wants to merge 3 commits into
Closed
bpo-34443: Change enum __repr__s and __str__s to use the fully qualified name#9011orlnub123 wants to merge 3 commits into
orlnub123 wants to merge 3 commits into
Conversation
Contributor
Author
|
I'll fix the tests tomorrow. |
Contributor
|
@orlnub123 not sure why you would create a separate PR for the same issue. |
Contributor
Author
|
@prakashdanish I thought I'd create another one because it's doing something different. |
Contributor
Author
|
It looks like I got confused about the datetime thing. Now I'm questioning whether this is a good change or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason I've also changed the
__str__s is to keep consistency with the__repr__s.The datetime module also follows this practice.https://bugs.python.org/issue34443