bpo-34512: Document platform-specific strftime() behavior for non-ASC…#8948
bpo-34512: Document platform-specific strftime() behavior for non-ASC…#8948
Conversation
…II format strings
| some platforms such code points are preserved intact in the output, while on | ||
| others ``strftime`` may raise :exc:`UnicodeError` or return an empty string | ||
| instead. | ||
|
|
There was a problem hiding this comment.
I haven't mentioned surrogate code points and surrogateescape error handler. Not sure whether we want to go to that level of detail.
time module docs should also be changed when/if we reach consensus on the wording.
There was a problem hiding this comment.
I tend to agree that we should avoid mentioning surrogates given the proposed wording.
|
Presumably this can be backported as far back as is supported at the moment, since this is a long-standing issue. |
| variations are common. To see the full set of format codes supported on your | ||
| platform, consult the :manpage:`strftime(3)` documentation. | ||
|
|
||
| Likewise, handling of format strings containing Unicode code points that can't |
There was a problem hiding this comment.
Suggestion: "Likewise" -> "For the same reason"
| platform, consult the :manpage:`strftime(3)` documentation. | ||
|
|
||
| Likewise, handling of format strings containing Unicode code points that can't | ||
| be represented in the charset of the current locale is platform-dependent. On |
There was a problem hiding this comment.
"... is also platform-dependent."
|
@taleinat Thank you for the review! I've made the requested changes. |
|
I removed the " needs backport to 3.6" label, the 3.6 branch no longer accept bugfixes (only security fixes are accepted): https://devguide.python.org/#status-of-python-branches |
|
GH-11535 is a backport of this pull request to the 3.7 branch. |
…II format strings (pythonGH-8948) (cherry picked from commit 1cffd0e) Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>
|
GH-11536 is a backport of this pull request to the 2.7 branch. |
…II format strings (pythonGH-8948) (cherry picked from commit 1cffd0e) Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>
…II format strings
https://bugs.python.org/issue34512