bpo-34207: Fix pymain_init_cmdline_argv()#8867
Closed
vstinner wants to merge 1 commit into
Closed
Conversation
bpo-34170, bpo-34207: Fix pymain_init_cmdline_argv() * Add _Py_DecodeUTF8() * pymain_init_cmdline_argv() now calls directly _Py_DecodeUTF8() if the UTF-8 mode is enabled Previously, pymain_init_cmdline_argv() always called Py_DecodeLocale() which depends on Py_UTF8Mode, whereas this variable is no longer modified when reading the current configuration.
Member
Author
|
I tested manually that this change fix test_cmd_line on FreeBSD when run in an empty environment: |
Member
Author
|
I'm not sure that this change is enough: _PyCoreConfig_Read() calls _PyCoreConfig_InitPathConfig() which later indirectly calls _Py_EncodeLocaleRaw() which also depends on Py_UTF8Mode. |
Member
Author
|
Hum, this PR is incomplete because of Py_EncodeLocale() and similar functions. I wrote PR #8868 which is more generic and so safer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bpo-34170, bpo-34207: Fix pymain_init_cmdline_argv()
the UTF-8 mode is enabled
Previously, pymain_init_cmdline_argv() always called
Py_DecodeLocale() which depends on Py_UTF8Mode, whereas this variable
is no longer modified when reading the current configuration.