bpo-34212: Adds -DPy_BUILD_CORE_BUILTIN for modules statically linked into libpython#8446
Closed
embray wants to merge 1 commit into
python:masterpython/cpython:masterfrom
embray:cygwin/builtin-module-linkageembray/cpython:cygwin/builtin-module-linkageCopy head branch name to clipboard
Closed
bpo-34212: Adds -DPy_BUILD_CORE_BUILTIN for modules statically linked into libpython#8446embray wants to merge 1 commit intopython:masterpython/cpython:masterfrom embray:cygwin/builtin-module-linkageembray/cpython:cygwin/builtin-module-linkageCopy head branch name to clipboard
embray wants to merge 1 commit into
python:masterpython/cpython:masterfrom
embray:cygwin/builtin-module-linkageembray/cpython:cygwin/builtin-module-linkageCopy head branch name to clipboard
Conversation
…ically linked into libpython
Contributor
Author
|
I spent enough time understanding the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not happy with this solution since the
-DPy_BUILD_CORE_BUILTINis required for every module built into libpython that doesn't already define-DPy_BUILD_CORE. So perhaps this should be done automatically, such as byModules/makesetup, though I'm mildly afraid to touch that...This along with #8445 are the minimal needed for Python 3.7+ to build on Cygwin again.
https://bugs.python.org/issue34212