Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

bpo-29162: IDLE: import sys before we use it on line 9#828

Merged
terryjreedy merged 1 commit into
python:masterpython/cpython:masterfrom
JelleZijlstra:patch-6JelleZijlstra/cpython:patch-6Copy head branch name to clipboard
Mar 27, 2017
Merged

bpo-29162: IDLE: import sys before we use it on line 9#828
terryjreedy merged 1 commit into
python:masterpython/cpython:masterfrom
JelleZijlstra:patch-6JelleZijlstra/cpython:patch-6Copy head branch name to clipboard

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Mar 26, 2017

Copy link
Copy Markdown
Member

No description provided.

@mention-bot

mention-bot commented Mar 26, 2017

Copy link
Copy Markdown

@JelleZijlstra, thanks for your PR! By analyzing the history of the files in this pull request, we identified @terryjreedy, @kbkaiser and @ned-deily to be potential reviewers.

@Mariatta Mariatta added the type-bug An unexpected behavior, bug, or error label Mar 26, 2017
@terryjreedy terryjreedy self-assigned this Mar 27, 2017
@terryjreedy

terryjreedy commented Mar 27, 2017

Copy link
Copy Markdown
Member

Thank you both for the catch and review. This is a continuation of bpo-29162 (correct spelling?) and its incomplete fix. This time, there is no substitute for moving the import of sys.

Can either of you modify the title appropriately, so this will (maybe) get linked to the issue? I have not yet gotten up to speed with git and github. I will then hit [Squash and merge].

3.6 is the only backport needed, and no revision will be needed.

@Mariatta Mariatta changed the title IDLE: import sys before we use it on line 9 bpo-29162: IDLE: import sys before we use it on line 9 Mar 27, 2017
@terryjreedy terryjreedy merged commit 0579e81 into python:master Mar 27, 2017
@terryjreedy

terryjreedy commented Mar 27, 2017

Copy link
Copy Markdown
Member

Can one of you do the backport/cherry-pick?

@Mariatta

Mariatta commented Mar 27, 2017

Copy link
Copy Markdown
Member

Thanks for the merge, @terryjreedy :) I'll backport this to 3.6

@JelleZijlstra JelleZijlstra deleted the patch-6 branch March 27, 2017 02:23
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Mar 27, 2017
@JelleZijlstra @Mariatta
import sys before we use it on line 9 (python#828)
53815ef 
(cherry picked from commit 0579e81)
@Mariatta

Mariatta commented Mar 27, 2017

Copy link
Copy Markdown
Member

backport PR at GH-828

Mariatta added a commit that referenced this pull request Mar 27, 2017
@Mariatta
import sys before we use it on line 9 (GH-828) (GH-833)
d2fc782 
(cherry picked from commit 0579e81)
@Mariatta

Mariatta commented Mar 27, 2017

Copy link
Copy Markdown
Member

Wrong link earlier. Backport PR was at GH-833, and it's been merged to 3.6.

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mariatta Mariatta Mariatta approved these changes

Assignees

@terryjreedy terryjreedy

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JelleZijlstra @mention-bot @terryjreedy @Mariatta @the-knights-who-say-ni
Morty Proxy This is a proxified and sanitized view of the page, visit original site.