bpo-11572: Make several minor improvements to copy module#8208
Merged
berkerpeksag merged 1 commit intoJul 9, 2018
python:masterpython/cpython:masterfrom
berkerpeksag:11572-copy-improvementsberkerpeksag/cpython:11572-copy-improvementsCopy head branch name to clipboard
Merged
bpo-11572: Make several minor improvements to copy module#8208berkerpeksag merged 1 commit intopython:masterpython/cpython:masterfrom berkerpeksag:11572-copy-improvementsberkerpeksag/cpython:11572-copy-improvementsCopy head branch name to clipboard
berkerpeksag merged 1 commit into
python:masterpython/cpython:masterfrom
berkerpeksag:11572-copy-improvementsberkerpeksag/cpython:11572-copy-improvementsCopy head branch name to clipboard
Conversation
* When doing getattr lookups with a default of "None", it now uses an "is" comparison against None which is more correct * Removed outdated code Patch by Brandon Rhodes.
serhiy-storchaka
approved these changes
Jul 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
now uses an "is" comparison against None which is more
correct
Patch by Brandon Rhodes.
https://bugs.python.org/issue11572