[3.7] bpo-34044: subprocess.Popen copies startupinfo (GH-8090)#8120
Closed
miss-islington wants to merge 1 commit into
python:3.7python/cpython:3.7from
miss-islington:backport-483422f-3.7miss-islington/cpython:backport-483422f-3.7Copy head branch name to clipboard
Closed
[3.7] bpo-34044: subprocess.Popen copies startupinfo (GH-8090)#8120miss-islington wants to merge 1 commit intopython:3.7python/cpython:3.7from miss-islington:backport-483422f-3.7miss-islington/cpython:backport-483422f-3.7Copy head branch name to clipboard
miss-islington wants to merge 1 commit into
python:3.7python/cpython:3.7from
miss-islington:backport-483422f-3.7miss-islington/cpython:backport-483422f-3.7Copy head branch name to clipboard
Conversation
subprocess.Popen now copies the startupinfo argument to leave it unchanged: it will modify the copy, so that the same STARTUPINFO object can be used multiple times. Add subprocess.STARTUPINFO.copy() method. (cherry picked from commit 483422f) Co-authored-by: Victor Stinner <vstinner@redhat.com>
Member
|
I don't think that it's ok to add a public STARTUPINFO.copy() method in 3.7.1, so I created a backport manually to make the method private: PR 8121. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
subprocess.Popen now copies the startupinfo argument to leave it
unchanged: it will modify the copy, so that the same STARTUPINFO
object can be used multiple times.
Add subprocess.STARTUPINFO.copy() method.
(cherry picked from commit 483422f)
Co-authored-by: Victor Stinner vstinner@redhat.com
https://bugs.python.org/issue34044