A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ronaldoussoren

Thank you for a quick review.
I will add a new test soon!
Thanks!

@ronaldoussoren

https://github.com/python/cpython/blob/master/Lib/test/crashers/recursive_call.py

As far as I know, a unit test for USE_STACKCHECK is only /Lib/test/crashers/recursive_call.py.
Although I added this test on test_sys.py both Windows and macOS is failed on the CI except my local.
Is there any reference that I didn't catch?

@ronaldoussoren
Hmm maybe, I can add a new test on test_sys.py.
I will try it soon.

I added a logic for estimating a new stack space by using the stack space that was just needed.

@vstinner cc @ronaldoussoren

Thank you for the kind review and thank you for the guide about how to use ThreadState.

• Change the store area about stack size tracing into ThreadState for TLS purpose, not ThreadState->interp.
• There is an API that can change the stack size, but it will apply to the newly created thread. Should we care about it? threading.stack_size
• So I locally run the script with threading and it works well.

Sorry, I found an issue with this PR.
I will ping you after this issue is resolved.

@vstinner
Sorry for the verbose message.
The issue was not related to this PR.
After make clean it works well on my local machine.
Please take a look when you have time.

Thanks for understanding.

@vstinner I applied your review and some of the issues are under investigation.

List

• Do you know if it's implemented in pure userspace, or if it's a system call?
• Is this function available on GCC and Clang? -> clang okay, GCC is needed check
• Honestly, I'm not super excited by the implementation. I'm not sure that it's correct. ->
  I wonder to know there is a good way to running some of the scripts that can be run by this patch.

@corona10, is this still waiting changes or should it be moved back to code review? Thanks!

@vstinner @ronaldoussoren Let's reopen this PR when we need this feature ;)