Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-33051: IDLE: Separate editor options from the general tab in config#6082

Closed
csabella wants to merge 2 commits into
python:mainpython/cpython:mainfrom
csabella:editortabcsabella/cpython:editortabCopy head branch name to clipboard
Closed

bpo-33051: IDLE: Separate editor options from the general tab in config#6082
csabella wants to merge 2 commits into
python:mainpython/cpython:mainfrom
csabella:editortabcsabella/cpython:editortabCopy head branch name to clipboard

Conversation

@csabella

@csabella csabella commented Mar 11, 2018

Copy link
Copy Markdown
Contributor

Split the 'Editor Preferences' section of the General tab in configdialog into its own tab.

https://bugs.python.org/issue33051

@terryjreedy

terryjreedy commented May 17, 2018

Copy link
Copy Markdown
Member

I am skimming through some of your open IDLE patches before quitting for the night. In particular, are there any that can/should be merged before 3.7.0c1 next Tuesday? This looks like a straightforward cut/paste with light editing. I still must look at dialog itself. If I like it, YES.

@csabella

Copy link
Copy Markdown
Contributor Author

@terryjreedy I looked through the other open IDLE patches I have. Two of them have new tests for editor.py, so those would probably be too big to try to look at before Tuesday. I don't know if this is one you'd want to check before then - #5011.

@csabella csabella closed this Jun 4, 2018
@csabella csabella deleted the editortab branch June 4, 2018 17:24
@csabella

csabella commented Jun 4, 2018

Copy link
Copy Markdown
Contributor Author

Closing this was unintentional but I need to see if I can recreate the branch to reopen it.

Restored and rebased to master.

@vstinner

Copy link
Copy Markdown
Member

I removed the " needs backport to 3.6" label, the 3.6 branch no longer accept bugfixes (only security fixes are accepted): https://devguide.python.org/#status-of-python-branches

@terryjreedy

Copy link
Copy Markdown
Member

Closing as obsolete. init_validators was separately added and used on the existing GenPage. #26621 is a similar patch that separated windows preferences from Shell and Edit preferences. I did it after moving helplist to extensions tab and creating an ExtPage class. Moving indent spaces, #22954, completes the major changes we start around 3 years ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.