bpo-29768: Fixed compile-time check for expat version.#574
Merged
serhiy-storchaka merged 1 commit intoMar 9, 2017
python:masterpython/cpython:masterfrom
serhiy-storchaka:bpo-29768-check-expat-versionserhiy-storchaka/cpython:bpo-29768-check-expat-versionCopy head branch name to clipboard
Merged
bpo-29768: Fixed compile-time check for expat version.#574serhiy-storchaka merged 1 commit intopython:masterpython/cpython:masterfrom serhiy-storchaka:bpo-29768-check-expat-versionserhiy-storchaka/cpython:bpo-29768-check-expat-versionCopy head branch name to clipboard
serhiy-storchaka merged 1 commit into
python:masterpython/cpython:masterfrom
serhiy-storchaka:bpo-29768-check-expat-versionserhiy-storchaka/cpython:bpo-29768-check-expat-versionCopy head branch name to clipboard
Conversation
|
@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @freddrake, @loewis, @akuchling, @tiran and @brettcannon to be potential reviewers. |
Member
|
The change looks fine. I do suggest double checking to confirm that XML_COMBINED_VERSION is defined in whatever the oldest version of expat we expect people to encounter is (something crazy old like RHEL/CentOS 5 era ish I'd assume). |
Member
Author
|
|
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Mar 9, 2017
(cherry picked from commit 22e707f)
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Mar 9, 2017
(cherry picked from commit 22e707f)
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Mar 9, 2017
(cherry picked from commit 22e707f)
serhiy-storchaka
added a commit
that referenced
this pull request
Mar 9, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.