Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Miss islington backport bbbcf86 3.7#5503

Merged
warsaw merged 2 commits into
python:3.7python/cpython:3.7from
warsaw:miss-islington-backport-bbbcf86-3.7warsaw/cpython:miss-islington-backport-bbbcf86-3.7Copy head branch name to clipboard
Feb 3, 2018
Merged

Miss islington backport bbbcf86 3.7#5503
warsaw merged 2 commits into
python:3.7python/cpython:3.7from
warsaw:miss-islington-backport-bbbcf86-3.7warsaw/cpython:miss-islington-backport-bbbcf86-3.7Copy head branch name to clipboard

Conversation

@warsaw

@warsaw warsaw commented Feb 2, 2018

Copy link
Copy Markdown
Member

A manual backport is safer than #5498 because of the changes to importlib.h and importlib_external.h.

* Make sure ``__spec__.loader`` matches ``__loader__`` for namespace packages.
* Make sure ``__spec__.origin` matches ``__file__`` for namespace packages.

https://bugs.python.org/issue32303
https://bugs.python.org/issue32305
(cherry picked from commit bbbcf86)

Co-authored-by: Barry Warsaw <barry@python.org>
@bedevere-bot

Copy link
Copy Markdown

@warsaw: Please replace # with GH- in the commit message next time. Thanks!

@warsaw warsaw deleted the miss-islington-backport-bbbcf86-3.7 branch February 3, 2018 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.