bpo-10381: Test that new_timezone can return the UTC singleton#5318
Merged
abalkin merged 1 commit intoFeb 22, 2018
python:masterpython/cpython:masterfrom
pganssle:utc_singleton_api_testpganssle/cpython:utc_singleton_api_testCopy head branch name to clipboard
Merged
bpo-10381: Test that new_timezone can return the UTC singleton#5318abalkin merged 1 commit intopython:masterpython/cpython:masterfrom pganssle:utc_singleton_api_testpganssle/cpython:utc_singleton_api_testCopy head branch name to clipboard
abalkin merged 1 commit into
python:masterpython/cpython:masterfrom
pganssle:utc_singleton_api_testpganssle/cpython:utc_singleton_api_testCopy head branch name to clipboard
Conversation
Member
|
@ned-deily - as a tests-only change, I think this can go in 3.7. |
abalkin
approved these changes
Feb 22, 2018
Member
|
@abalkin Sure, as a feature fix, go ahead and merge to master and allow backport to 3.7. |
Contributor
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 22, 2018
(cherry picked from commit a049f57) Co-authored-by: Paul Ganssle <pganssle@users.noreply.github.com>
|
GH-5819 is a backport of this pull request to the 3.7 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I was fixing #5317, I realized that we are currently not testing the behavior that
new_timezonewill return the UTC singleton if provided a zero offset and no name.I'm referring this to the original issue, since this is really more of an oversight in the original test suite than a new issue. Since it has no behavior change and only affects an unreleased feature, I have not added news.
CC: @abalkin
https://bugs.python.org/issue10381