Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

bpo-32596: Make lazy-load portable#5316

Merged
methane merged 1 commit into
python:masterpython/cpython:masterfrom
methane:concurrent-futuresmethane/cpython:concurrent-futuresCopy head branch name to clipboard
Jan 26, 2018
Merged

bpo-32596: Make lazy-load portable#5316
methane merged 1 commit into
python:masterpython/cpython:masterfrom
methane:concurrent-futuresmethane/cpython:concurrent-futuresCopy head branch name to clipboard

Conversation

@methane

@methane methane commented Jan 25, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@methane
bpo-32596: Make lazy-load portable
992c48d 
Global variables should not used as import target.
Use temporary variable instead.
ilevkivskyi
ilevkivskyi approved these changes Jan 25, 2018
View reviewed changes

@ilevkivskyi ilevkivskyi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@methane methane merged commit 4666ec5 into python:master Jan 26, 2018
@methane methane deleted the concurrent-futures branch January 26, 2018 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@methane @ilevkivskyi @the-knights-who-say-ni @bedevere-bot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.