Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-32634: fix write in email/generator.py#5267

Closed
reb00ter wants to merge 9 commits into
python:masterpython/cpython:masterfrom
reb00ter:patch-1reb00ter/cpython:patch-1Copy head branch name to clipboard
Closed

bpo-32634: fix write in email/generator.py#5267
reb00ter wants to merge 9 commits into
python:masterpython/cpython:masterfrom
reb00ter:patch-1reb00ter/cpython:patch-1Copy head branch name to clipboard

Conversation

@reb00ter

@reb00ter reb00ter commented Jan 22, 2018

Copy link
Copy Markdown

add_header when email dont have it

https://bugs.python.org/issue32634

add_header when email dont have it
@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@reb00ter reb00ter changed the title Update generator.py bpo-3264: fix write in email/generator.py Jan 23, 2018
@reb00ter reb00ter changed the title bpo-3264: fix write in email/generator.py bpo-32634: fix write in email/generator.py Jan 23, 2018
@matrixise

Copy link
Copy Markdown
Member

Hi @reb00ter

Thank you for your contribution, it's great.

But for my part, I have few points.

  1. there is no new tests with your fix
  2. you have cleaned the code but it's not needed maybe you could just submit your fix and not the cleaning.

@bitdancer and @warsaw are the experts for the email part and I would like to have their opinion.

Thank you

@bitdancer

Copy link
Copy Markdown
Member

Thanks for your work, but there is an existing PR for this almost ready to go (#1977). Also, FYI the style changes would have been rejected.

@bitdancer bitdancer closed this Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.