bpo-24037: Add Argument Clinic converter bool(accept={int}).#485
Merged
serhiy-storchaka merged 4 commits intoMar 12, 2017
python:masterpython/cpython:masterfrom
serhiy-storchaka:bpo-24037-clinic-boolint-converterserhiy-storchaka/cpython:bpo-24037-clinic-boolint-converterCopy head branch name to clipboard
Merged
bpo-24037: Add Argument Clinic converter bool(accept={int}).#485serhiy-storchaka merged 4 commits intopython:masterpython/cpython:masterfrom serhiy-storchaka:bpo-24037-clinic-boolint-converterserhiy-storchaka/cpython:bpo-24037-clinic-boolint-converterCopy head branch name to clipboard
bool(accept={int}).#485serhiy-storchaka merged 4 commits into
python:masterpython/cpython:masterfrom
serhiy-storchaka:bpo-24037-clinic-boolint-converterserhiy-storchaka/cpython:bpo-24037-clinic-boolint-converterCopy head branch name to clipboard
Conversation
|
@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjaminp, @ezio-melotti, @Haypo, @doerwalter and @loewis to be potential reviewers. |
vstinner
approved these changes
Mar 6, 2017
duboviy
approved these changes
Mar 11, 2017
vadmium
reviewed
Mar 11, 2017
|
|
||
| - bpo-24037: Argument Clinic now uses the converter `bool(accept={int})` rather | ||
| of `int` for semantical booleans. This allows to not repeat the default | ||
| value for Python and C and will help in converting to `bool` in future. |
Member
There was a problem hiding this comment.
rather of → rather than
This allows to not repeat . . . → This avoids repeating . . . [see earlier changes I made regarding “allows to”: https://bugs.python.org/issue26304]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is used for semantical booleans using 'i' format unit. This allows to not repeat the default value for Python and C and will help in converting to
boolin future.