bpo-25910: Fixes redirection from http to https#4674
bpo-25910: Fixes redirection from http to https#4674vstinner merged 3 commits intopython:masterpython/cpython:masterfrom CuriousLearner:fix-links-http-to-httpsCuriousLearner/cpython:fix-links-http-to-httpsCopy head branch name to clipboard
Conversation
| releases, it also offers a number of features via pure Python | ||
| extensions that are not available in other language bindings. There | ||
| is an active wxPython user and developer community. | ||
| wxPython (https://www.wxpython.org) is the Python binding for wxwidgets. |
There was a problem hiding this comment.
Would you mind to create a link?
`wxPython <url>`_
| extensions that are not available in other language bindings. There | ||
| is an active wxPython user and developer community. | ||
| wxPython (https://www.wxpython.org) is the Python binding for wxwidgets. | ||
| While it often lags slightly behind the official wxWidgets releases, it also |
There was a problem hiding this comment.
@vadmium asked you to not reformat links like this, please restrict this PR to HTTPS.
There was a problem hiding this comment.
Apologies for that. I just extracted the same old changes from the earlier patch. I'll fix this.
|
|
||
| See http://cx-freeze.sourceforge.net/ for a distutils extension that allows you | ||
| to create console and GUI executables from Python code. | ||
| See https://anthony-tuininga.github.io/cx_Freeze/ for a distutils extension |
There was a problem hiding this comment.
Please create a link. You may be able to omit the url here, since it's written in a previous section (check the HTML output, I'm not sure).
`cx_Freeze`_
| You should have received a copy of the CC0 Public Domain Dedication along | ||
| with this software. If not, see | ||
| http://creativecommons.org/publicdomain/zero/1.0/. | ||
| https://creativecommons.org/publicdomain/zero/1.0/. |
There was a problem hiding this comment.
This text is a license. Is it ok to modify a license?
There was a problem hiding this comment.
I'm not sure about that. Should I ask this on the bug?
There was a problem hiding this comment.
I think it's ok. I take the responsability for this change ;-)
| :mod:`distutils` extension (see :ref:`extending-distutils`) which wraps | ||
| Python scripts into executable Windows programs (:file:`{*}.exe` files). | ||
| When you have done this, you can distribute your application without | ||
| requiring your users to install Python. |
There was a problem hiding this comment.
Again, please revert this change, only replace the HTTP link.
| tests. It's not as fancy as `py.test <http://pytest.org>`__ or | ||
| `nose <http://code.google.com/p/python-nose/>`__, but provides a simple way | ||
| to run tests kept within a set of package directories. For example, | ||
| `nose <https://code.google.com/archive/p/python-nose>`__, but provides a |
There was a problem hiding this comment.
This link seems undated. The new home is more https://nose.readthedocs.io/ no?
There was a problem hiding this comment.
Seems like you're right about it. The make linkcheck command showed me this as a 301. So, I updated it to point to this link.
| Tools that use or will use the new syntax: | ||
| `mypy <http://github.com/python/mypy>`_, | ||
| `pytype <http://github.com/google/pytype>`_, PyCharm, etc. | ||
| `mypy <https://github.com/python/mypy>`_, |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @vstinner: please review the changes made to this pull request. |
| You should have received a copy of the CC0 Public Domain Dedication along | ||
| with this software. If not, see | ||
| http://creativecommons.org/publicdomain/zero/1.0/. | ||
| https://creativecommons.org/publicdomain/zero/1.0/. |
There was a problem hiding this comment.
I think it's ok. I take the responsability for this change ;-)
|
Thanks @CuriousLearner, I merged your PR. |
|
Thanks @vstinner. |
|
Thanks @CuriousLearner for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6. |
|
Sorry, @CuriousLearner and @vstinner, I could not cleanly backport this to |
|
Sorry, please ignore the backport to 3.6 noise! |
This PR extracts changes from #1933
Currently focuses mostly on fixing link redirection from http to https.
cc @vstinner
https://bugs.python.org/issue25910