bpo-31174: Improve the code of test_tools.test_unparse.#4146
Merged
serhiy-storchaka merged 1 commit intoOct 27, 2017
python:masterpython/cpython:masterfrom
serhiy-storchaka:test_unparse-get_namesserhiy-storchaka/cpython:test_unparse-get_namesCopy head branch name to clipboard
Merged
bpo-31174: Improve the code of test_tools.test_unparse.#4146serhiy-storchaka merged 1 commit intopython:masterpython/cpython:masterfrom serhiy-storchaka:test_unparse-get_namesserhiy-storchaka/cpython:test_unparse-get_namesCopy head branch name to clipboard
serhiy-storchaka merged 1 commit into
python:masterpython/cpython:masterfrom
serhiy-storchaka:test_unparse-get_namesserhiy-storchaka/cpython:test_unparse-get_namesCopy head branch name to clipboard
Conversation
Contributor
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 27, 2017
(cherry picked from commit 7351f9e)
|
GH-4148 is a backport of this pull request to the 3.6 branch. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Oct 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
get_names()is an instance method, it shouldn't cache its result statically. It should be a static method, but a class method works as well.https://bugs.python.org/issue31174