Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[3.6] bpo-31174: Fix test_tools.test_unparse (GH-4102)#4104

Merged
vstinner merged 1 commit into
python:3.6python/cpython:3.6from
miss-islington:backport-8e482be-3.6miss-islington/cpython:backport-8e482be-3.6Copy head branch name to clipboard
Oct 24, 2017
Merged

[3.6] bpo-31174: Fix test_tools.test_unparse (GH-4102)#4104
vstinner merged 1 commit into
python:3.6python/cpython:3.6from
miss-islington:backport-8e482be-3.6miss-islington/cpython:backport-8e482be-3.6Copy head branch name to clipboard

Conversation

@miss-islington

@miss-islington miss-islington commented Oct 24, 2017

Copy link
Copy Markdown
Contributor

test_unparse.DirectoryTestCase now stores the names sample to always
test the same files. It prevents false alarms when hunting reference
leaks.
(cherry picked from commit 8e482be)

https://bugs.python.org/issue31174

test_unparse.DirectoryTestCase now stores the names sample to always
test the same files. It prevents false alarms when hunting reference
leaks.
(cherry picked from commit 8e482be)

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington

Copy link
Copy Markdown
Contributor Author

@Haypo: Backport status check is done, and it's a success ✅ .

@vstinner vstinner merged commit d8f78a1 into python:3.6 Oct 24, 2017
@miss-islington

Copy link
Copy Markdown
Contributor Author

Thanks, @Haypo!

@miss-islington miss-islington deleted the backport-8e482be-3.6 branch October 24, 2017 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.