Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-27200: fix faq/programming and datetime#401

Merged
berkerpeksag merged 4 commits into
python:masterpython/cpython:masterfrom
marco-buttu:fix-issue-27200-2ndCopy head branch name to clipboard
Mar 18, 2017
Merged

bpo-27200: fix faq/programming and datetime#401
berkerpeksag merged 4 commits into
python:masterpython/cpython:masterfrom
marco-buttu:fix-issue-27200-2ndCopy head branch name to clipboard

Conversation

@marco-buttu

@marco-buttu marco-buttu commented Mar 2, 2017

Copy link
Copy Markdown
Contributor

This PR partially fixes bpo-27200. Partially and not completely, because I followed the suggestion of @ezio-melotti to split the patch in several patches. This PR is the 2nd of the series, the first one was #240.
Here I changed the name of the file tzinfo-examples.py to tzinfo_examples.py, for two reasons. The first one is the PEP8 conformity. The second one is that tzinfo-examples could not be imported to execute the interactive example. It is not just a problem of doctest. The real problem is that the reader actually can not execute the example without renaming tzinfo-examples in something else (without the -).

Comment thread Doc/library/datetime.rst Outdated
.. doctest::

>>> from datetime import datetime, timezone
>>> from tzinfo_examples import HOUR, Eastern

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just added the two lines above, and deindented all the example of 1 whitespace, to fit the doctest directive indentation.

@berkerpeksag berkerpeksag merged commit 909a6f6 into python:master Mar 18, 2017
@berkerpeksag

Copy link
Copy Markdown
Member

Thanks!

jaraco pushed a commit that referenced this pull request Dec 2, 2022
Bumps [codecov](https://github.com/codecov/codecov-python) from 2.1.9 to 2.1.10.
- [Release notes](https://github.com/codecov/codecov-python/releases)
- [Changelog](https://github.com/codecov/codecov-python/blob/master/CHANGELOG.md)
- [Commits](codecov/codecov-python@v2.1.9...v2.1.10)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Mariatta <Mariatta@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.