bpo-31553: Add --jsonlines option to json.tool.#3846
Closed
jeffreyrack wants to merge 10 commits into
Closed
bpo-31553: Add --jsonlines option to json.tool.#3846jeffreyrack wants to merge 10 commits into
jeffreyrack wants to merge 10 commits into
Conversation
RadixSeven
reviewed
Oct 2, 2017
| parser.add_argument('--sort-keys', action='store_true', default=False, | ||
| help='sort the output of dictionaries alphabetically by key') | ||
| parser.add_argument('--jsonlines', action='store_true', default=False, | ||
| help='Parse output using the jsonlines format.') |
There was a problem hiding this comment.
I think there are three typos here: Parse output -> parse input (the other help texts are not capitalized) and the other texts don't end in a period.
lisroach
requested changes
Oct 16, 2017
| import json | ||
| import sys | ||
|
|
||
| def parse_json_from_filehandle(infile, sort_keys): |
Contributor
There was a problem hiding this comment.
These functions are a bit repetitive and add a lot of unnecessary lines of code. I think they could be avoided by keeping the functionality in the original location. The code could become more like:
sort_keys = options.sort_keys
jsonlines = options.jsonlines
with infile:
if jsonlines:
if sort_keys:
objs = [json.loads(line) for line in infile]
else:
...
else:
if sort_keys:
objs = [json.load(infile)]
else:
...
This keeps the code more concise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the --jsonlines option to the json.tool utility in order to parse input that is passed using the jsonlines formatting.
https://bugs.python.org/issue31553
https://bugs.python.org/issue31553