[3.6] bpo-31323: Fix reference leak in test_ssl (GH-3263)#3538
Merged
vstinner merged 1 commit intoSep 13, 2017
python:3.6python/cpython:3.6from
miss-islington:backport-8687101-3.6miss-islington/cpython:backport-8687101-3.6Copy head branch name to clipboard
Merged
[3.6] bpo-31323: Fix reference leak in test_ssl (GH-3263)#3538vstinner merged 1 commit intopython:3.6python/cpython:3.6from miss-islington:backport-8687101-3.6miss-islington/cpython:backport-8687101-3.6Copy head branch name to clipboard
vstinner merged 1 commit into
python:3.6python/cpython:3.6from
miss-islington:backport-8687101-3.6miss-islington/cpython:backport-8687101-3.6Copy head branch name to clipboard
Conversation
Store exceptions as string rather than object to prevent reference cycles which cause leaking dangling threads. (cherry picked from commit 8687101)
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
Contributor
Author
|
Thanks, @Haypo! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store exceptions as string rather than object to prevent reference
cycles which cause leaking dangling threads.
(cherry picked from commit 8687101)
https://bugs.python.org/issue31323