Revert "bpo-44800: Document internal frame naming conventions"#32301
Merged
markshannon merged 1 commit intoApr 4, 2022
mainpython/cpython:mainfrom
revert-32281-bpo-44800-document-status-quopython/cpython:revert-32281-bpo-44800-document-status-quoCopy head branch name to clipboard
Merged
Revert "bpo-44800: Document internal frame naming conventions"#32301markshannon merged 1 commit intomainpython/cpython:mainfrom revert-32281-bpo-44800-document-status-quopython/cpython:revert-32281-bpo-44800-document-status-quoCopy head branch name to clipboard
markshannon merged 1 commit into
mainpython/cpython:mainfrom
revert-32281-bpo-44800-document-status-quopython/cpython:revert-32281-bpo-44800-document-status-quoCopy head branch name to clipboard
Conversation
|
@markshannon: Please replace |
Member
Author
|
See #32304 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #32281 as it is both misleading in general and incorrect in detail.
General:
Listing each field, and stating its name, is pointless and just gets in the way of reading the code which contains the same information and is guaranteed unambiguous and up to date.
The language is vague, and is misleading when describing why there are two structs,
PyInterpeterFrame, andPyFrameObjectand what their roles are.Detail:
There is no
f_statefield (andf_lastiwill be replaced imminently).https://bugs.python.org/issue44800