Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-30121: Write an unit test#3133

Merged
vstinner merged 1 commit into
python:masterpython/cpython:masterfrom
vstinner:test_nonexisting_pipesCopy head branch name to clipboard
Aug 21, 2017
Merged

bpo-30121: Write an unit test#3133
vstinner merged 1 commit into
python:masterpython/cpython:masterfrom
vstinner:test_nonexisting_pipesCopy head branch name to clipboard

Conversation

@vstinner

@vstinner vstinner commented Aug 18, 2017

Copy link
Copy Markdown
Member

Test the Popen failure when created with pipes

Create also NON_EXISTING_CMD variable in test_subprocess.py.

https://bugs.python.org/issue30121

@vstinner

Copy link
Copy Markdown
Member Author

cc @segevfiner

bpo-30121: Test the Popen failure when Popen was created with pipes.
Create also NONEXISTING_CMD variable in test_subprocess.py.
@vstinner vstinner merged commit 9a83f65 into python:master Aug 21, 2017
@vstinner vstinner deleted the test_nonexisting_pipes branch August 21, 2017 21:51
vstinner added a commit that referenced this pull request Aug 21, 2017
…3173)

* bpo-30121: Fix debug assert in subprocess on Windows (#1224)

* bpo-30121: Fix debug assert in subprocess on Windows

This is caused by closing HANDLEs using os.close which is for CRT file
descriptors and not for HANDLEs.

* bpo-30121: Suppress debug assertion in test_subprocess when ran directly

(cherry picked from commit 4d38517)

* Add test_subprocess.test_nonexisting_with_pipes() (#3133)

bpo-30121: Test the Popen failure when Popen was created with pipes.
Create also NONEXISTING_CMD variable in test_subprocess.py.
(cherry picked from commit 9a83f65)
GadgetSteve pushed a commit to GadgetSteve/cpython that referenced this pull request Sep 10, 2017
bpo-30121: Test the Popen failure when Popen was created with pipes.
Create also NONEXISTING_CMD variable in test_subprocess.py.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.