Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-46520: Handle identifiers that look like keywords in ast.unparse#31012

Open
Kodiologist wants to merge 6 commits into
python:mainpython/cpython:mainfrom
Kodiologist:fix-issue-46520Kodiologist/cpython:fix-issue-46520Copy head branch name to clipboard
Open

bpo-46520: Handle identifiers that look like keywords in ast.unparse#31012
Kodiologist wants to merge 6 commits into
python:mainpython/cpython:mainfrom
Kodiologist:fix-issue-46520Kodiologist/cpython:fix-issue-46520Copy head branch name to clipboard

Conversation

@Kodiologist

@Kodiologist Kodiologist commented Jan 29, 2022

Copy link
Copy Markdown
Contributor

Handle identifiers that look like keywords in ast.unparse

https://bugs.python.org/issue46520

@terryjreedy

Copy link
Copy Markdown
Member

@ezio-melotti Did you intend to remove the CLA-signed label? (I saw this on another PR and wondered there too.) Does Kodi need to sign or re-sign to get this reviewed?

@terryjreedy

Copy link
Copy Markdown
Member

Kodi, please replace your private joke and its response with a draft commit message. At first glance, it makes this look like spam, and obstructing merging that way makes this look non-serious.

@ezio-melotti

ezio-melotti commented Aug 9, 2022

Copy link
Copy Markdown
Member

@terryjreedy: the CLA-signed label got removed and replaced by the clabot. All PRs must now pass the "CLA Signing" check before being merged. You can retrigger the check by closing and reopening the PR.

Edit: clicking on the "Update branch" button should also retrigger the check.

@Kodiologist

Copy link
Copy Markdown
Contributor Author

Kodi, please replace your private joke and its response with a draft commit message.

I've changed the text of the first post, but I don't have the power to change or remove reactions, if that's what you mean by "its response". In fact, I don't think GitHub lets any users do that.

@terryjreedy terryjreedy closed this Aug 9, 2022
@terryjreedy terryjreedy reopened this Aug 9, 2022
@terryjreedy

Copy link
Copy Markdown
Member

Kodi, whatever you did before, you need to sign or re-sign the CLA

@Kodiologist

Copy link
Copy Markdown
Contributor Author

I signed it previously (by mail, if I recall correctly) and I got "Internal Server Error" when trying to click through the Heroku program, but @cpython-cla-bot seems to now think it's signed, so eh.

@python python deleted a comment Apr 7, 2025
@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 10, 2026
@Kodiologist

Copy link
Copy Markdown
Contributor Author

Still unreviewed after 4 years.

@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.