Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-12067: Add tests to test_compare#30667

Closed
humbdrag wants to merge 2 commits into
python:mainpython/cpython:mainfrom
humbdrag:bpo-12067humbdrag/cpython:bpo-12067Copy head branch name to clipboard
Closed

bpo-12067: Add tests to test_compare#30667
humbdrag wants to merge 2 commits into
python:mainpython/cpython:mainfrom
humbdrag:bpo-12067humbdrag/cpython:bpo-12067Copy head branch name to clipboard

Conversation

@humbdrag

@humbdrag humbdrag commented Jan 18, 2022

Copy link
Copy Markdown
Contributor

@humbdrag

Copy link
Copy Markdown
Contributor Author

This is not visible to users so I think "skip news" is applicable to this.

@terryjreedy

Copy link
Copy Markdown
Member

The changelog has a section Tests, so I see no reason to not mention extensive changes like this.

This seems nearly identical to #60625 and #30651 so the first should have been left open to get the revised CLA tag. But we can go with this one.

@humbdrag

Copy link
Copy Markdown
Contributor Author

The changelog has a section Tests, so I see no reason to not mention extensive changes like this.

This seems nearly identical to #60625 and #30651 so the first should have been left open to get the revised CLA tag. But we can go with this one.

Thanks for the reply. Good point, added news file.

@humbdrag

Copy link
Copy Markdown
Contributor Author

@terryjreedy Sorry for tagging but any further thoughts?

@terryjreedy

Copy link
Copy Markdown
Member

This appears more or less identical to the original PR, #3199, with original attributions and merge conflicts removed. Our workflow is to credit original authors and, when possible, to fix merge conflicts on the PR. I did so fairly easily, leaving this as redundant. If you have any comments or suggestions, please make them there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.