Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-40066: [Enum] fix doc and unit tests#30643

Merged
ethanfurman merged 1 commit into
python:mainpython/cpython:mainfrom
ethanfurman:40066-fix_testsethanfurman/cpython:40066-fix_testsCopy head branch name to clipboard
Jan 17, 2022
Merged

bpo-40066: [Enum] fix doc and unit tests#30643
ethanfurman merged 1 commit into
python:mainpython/cpython:mainfrom
ethanfurman:40066-fix_testsethanfurman/cpython:40066-fix_testsCopy head branch name to clipboard

Conversation

@ethanfurman

@ethanfurman ethanfurman commented Jan 17, 2022

Copy link
Copy Markdown
Member
  • skip doctest that changes depending on target system
  • substitute in values that change depending on target system

https://bugs.python.org/issue40066

- skip doctest that changes depending on target system
- substitute in values that change depending on target system

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe @kulikjak wants to test it on Solaris before it's merged?

@kulikjak kulikjak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I quickly tested those and now it works as expected.

@vstinner

Copy link
Copy Markdown
Member

@kulikjak: I quickly tested those and now it works as expected.

Cool, thanks for testing!

@ethanfurman ethanfurman merged commit 62a6594 into python:main Jan 17, 2022
@ethanfurman

Copy link
Copy Markdown
Member Author

Thanks everyone for your help.

@ethanfurman ethanfurman deleted the 40066-fix_tests branch November 23, 2022 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.