Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[3.10] bpo-46070: Revert "bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState (GH-17287)"#30565

Closed
vstinner wants to merge 2 commits into
python:3.10python/cpython:3.10from
vstinner:revert_gc310Copy head branch name to clipboard
Closed

[3.10] bpo-46070: Revert "bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState (GH-17287)"#30565
vstinner wants to merge 2 commits into
python:3.10python/cpython:3.10from
vstinner:revert_gc310Copy head branch name to clipboard

Conversation

@vstinner

@vstinner vstinner commented Jan 12, 2022

Copy link
Copy Markdown
Member

This reverts commit 7247407.

Fix a random crash involving subinterpreters on Windows. Revert the
change which made the gc module state per interpreter: the gc module
state is shared again by all interpreters.

https://bugs.python.org/issue36854

…rState (GH-17287)"

This reverts commit 7247407.

Fix a random crash involving subinterpreters on Windows. Revert the
change which made the gc module state per interpreter: the gc module
state is shared again by all interpreters.
@vstinner vstinner changed the title [3.10] Revert "bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState (GH-17287)" bpo-46070: [3.10] Revert "bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState (GH-17287)" Jan 12, 2022

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner changed the title bpo-46070: [3.10] Revert "bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState (GH-17287)" [3.10] bpo-46070: Revert "bpo-36854: Move _PyRuntimeState.gc to PyInterpreterState (GH-17287)" Jan 13, 2022
@vstinner

Copy link
Copy Markdown
Member Author

I wrote a simpler fix: GH-30577.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.