[3.6] bpo-19903: IDLE: Calltips changed to use inspect.signature (GH-2822)#3053
Merged
terryjreedy merged 2 commits intoAug 10, 2017
python:3.6python/cpython:3.6from
terryjreedy:backport-3b0f620-3.6terryjreedy/cpython:backport-3b0f620-3.6Copy head branch name to clipboard
Merged
[3.6] bpo-19903: IDLE: Calltips changed to use inspect.signature (GH-2822)#3053terryjreedy merged 2 commits intopython:3.6python/cpython:3.6from terryjreedy:backport-3b0f620-3.6terryjreedy/cpython:backport-3b0f620-3.6Copy head branch name to clipboard
terryjreedy merged 2 commits into
python:3.6python/cpython:3.6from
terryjreedy:backport-3b0f620-3.6terryjreedy/cpython:backport-3b0f620-3.6Copy head branch name to clipboard
Conversation
…honGH-2822) Idlelib.calltips.get_argspec now uses inspect.signature instead of inspect.getfullargspec, like help() does. This improves the signature in the call tip in a few different cases, including builtins converted to provide a signature. A message is added if the object is not callable, has an invalid signature, or if it has positional-only parameters. Patch by Louie Lu.. (cherry picked from commit 3b0f620)
Member
Author
|
The test part of the patch touched the one code line in idlelib where 3.6 and 3.7 differ, and created another conflict, so I had to resolve the merge conflict (see comment in diff) and test myself. If cherry_picker had run without conflict, I would have closed and re-open to get Appveyor to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue19903