Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[3.6] bpo-31160: Backport reap_children() fixes from master to 3.6#3046

Closed
vstinner wants to merge 2 commits into
python:3.6python/cpython:3.6from
vstinner:reap_children36Copy head branch name to clipboard
Closed

[3.6] bpo-31160: Backport reap_children() fixes from master to 3.6#3046
vstinner wants to merge 2 commits into
python:3.6python/cpython:3.6from
vstinner:reap_children36Copy head branch name to clipboard

Conversation

@vstinner

@vstinner vstinner commented Aug 9, 2017

Copy link
Copy Markdown
Member

PtyTests.run_child() now calls os.waitpid() to read the exit status
of the child process to avoid creating zombie process and leaking
processes in the background.
(cherry picked from commit 4baca1b)
Add a post_test_cleanup() function which currently only calls
support.reap_children().
(cherry picked from commit e3510d7)
@vstinner

vstinner commented Aug 9, 2017

Copy link
Copy Markdown
Member Author

The test_builtin change is wrong: http://bugs.python.org/issue31160#msg300024

@vstinner

Copy link
Copy Markdown
Member Author

I abandon this PR. I will redo it once I will have merged all reap_children() fixes into master, and that buildbots confirmed that everything is fine. More fixes are required than expected.

@vstinner vstinner closed this Aug 10, 2017
@vstinner vstinner deleted the reap_children36 branch August 10, 2017 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.