bpo-31150: Wait for child process in test_forkinthread#3032
Merged
Merged
bpo-31150: Wait for child process in test_forkinthread#3032
Conversation
…d reaped warnings
Member
|
I confirm that it fixes https://bugs.python.org/issue31150 so I merged your PR, thanks. Would you mind to backport it to 3.6 and 2.7? |
Contributor
|
🐍🍒⛏🤖 Thanks @ammaraskar for the PR, and @Haypo for merging it 🌮🎉.I'm working now to backport this PR to: 2.7, 3.6. |
Contributor
|
Sorry @ammaraskar and @Haypo, I had trouble checking out the backport branch.Please backport using cherry_picker on command line. |
Contributor
|
Sorry, @ammaraskar and @Haypo, I could not cleanly backport this PR due to a conflict. |
Member
|
@miss-islington: The change was already backported to 3.6 and 2.7 manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gets rid of the thread reaped warnings as shown in the bpo ticket.
https://bugs.python.org/issue31150