Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-45496: Allow flexibility in winfo_rgb tests#30185

Merged
serhiy-storchaka merged 4 commits into
python:mainpython/cpython:mainfrom
E-Paine:tkinter-winfo-rgbE-Paine/cpython:tkinter-winfo-rgbCopy head branch name to clipboard
Dec 26, 2021
Merged

bpo-45496: Allow flexibility in winfo_rgb tests#30185
serhiy-storchaka merged 4 commits into
python:mainpython/cpython:mainfrom
E-Paine:tkinter-winfo-rgbE-Paine/cpython:tkinter-winfo-rgbCopy head branch name to clipboard

Conversation

@E-Paine

@E-Paine E-Paine commented Dec 18, 2021

Copy link
Copy Markdown
Contributor

Allow a margin of 0.05% per colour channel to avoid tests failing on different hardware.

https://bugs.python.org/issue45496

@E-Paine

E-Paine commented Dec 18, 2021

Copy link
Copy Markdown
Contributor Author

Windows test failure is unrelated

Comment thread Lib/tkinter/test/test_tkinter/test_misc.py Outdated
Comment thread Misc/NEWS.d/next/Tests/2021-12-18-13-31-29.bpo-45496.lQsPOW.rst Outdated
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @E-Paine for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 26, 2021
(cherry picked from commit 2e3e0d2)

Co-authored-by: E-Paine <63801254+E-Paine@users.noreply.github.com>
@bedevere-bot

Copy link
Copy Markdown

GH-30266 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 26, 2021
(cherry picked from commit 2e3e0d2)

Co-authored-by: E-Paine <63801254+E-Paine@users.noreply.github.com>
@bedevere-bot

Copy link
Copy Markdown

GH-30267 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Dec 26, 2021
(cherry picked from commit 2e3e0d2)

Co-authored-by: E-Paine <63801254+E-Paine@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Dec 26, 2021
(cherry picked from commit 2e3e0d2)

Co-authored-by: E-Paine <63801254+E-Paine@users.noreply.github.com>
@E-Paine E-Paine deleted the tkinter-winfo-rgb branch January 6, 2022 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.