Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

bpo-40915: Fix a 32bit compiler warning in mmapmodule.c on Windows#30175

Merged
zooba merged 1 commit into
python:mainpython/cpython:mainfrom
neonene:bpo-40915Copy head branch name to clipboard
Dec 18, 2021
Merged

bpo-40915: Fix a 32bit compiler warning in mmapmodule.c on Windows#30175
zooba merged 1 commit into
python:mainpython/cpython:mainfrom
neonene:bpo-40915Copy head branch name to clipboard

Conversation

@neonene

@neonene neonene commented Dec 17, 2021

Copy link
Copy Markdown
Contributor

MSVC(x86) shows the following warning at mmap_resize_method() when building 3.11.

mmapmodule.c(539,58): warning C4244: '=':
conversion from 'LONGLONG' to 'Py_ssize_t', possible loss of data

https://bugs.python.org/issue40915

@neonene neonene changed the title bpo-40915: Fix a compiler warning in mmapmodule.c on Windows(32bit) bpo-40915: Fix a 32bit compiler warning in mmapmodule.c on Windows Dec 17, 2021
@zooba zooba merged commit 6214caa into python:main Dec 18, 2021
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @neonene for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington

Copy link
Copy Markdown
Contributor

Sorry, @neonene and @zooba, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6214caafbe66e34e84c1809abf0b7aab6791956b 3.10

@miss-islington

Copy link
Copy Markdown
Contributor

Sorry @neonene and @zooba, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 6214caafbe66e34e84c1809abf0b7aab6791956b 3.9

@zooba

zooba commented Dec 18, 2021

Copy link
Copy Markdown
Member

I don't have time right now to do backports, so if someone else wants to go right ahead. Remember to put [3.10] and [3.9] in the title of the PR

@neonene

neonene commented Dec 18, 2021

Copy link
Copy Markdown
Contributor Author

Only 3.11 changed mmapmodule.c and emits the warning.

@neonene

neonene commented Dec 18, 2021

Copy link
Copy Markdown
Contributor Author

Thanks @zooba and @AlexWaygood for the help.

@neonene neonene deleted the bpo-40915 branch December 18, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.